fix: remove smol-toml dependency from create-expert E2E test#607
Merged
fix: remove smol-toml dependency from create-expert E2E test#607
Conversation
Replace TOML parsing with simple string matching to avoid importing smol-toml (transitive dep not resolvable from e2e/ directory) or workspace packages (@perstack/perstack-toml) that bun test can't resolve outside the workspace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
fix/e2e-create-expert-toml
branch
from
02f0260 to
1fa0bc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOML.parse()(smol-toml) with simple string matching in create-expert E2E testsmol-tomlis a transitive dependency not resolvable from thee2e/directory, and@perstack/perstack-tomlis a workspace package thatbun testcan't resolve outside workspace scopeTest plan
🤖 Generated with Claude Code